All Articles

naming inconsistencies

Whenever I see code like this I sigh in despair:

constructor(private http: HttpClient,
            private httpErrorHandler: HttpErrorHandler) {}

If two such simple lines (or one depending on your format liking) are already inconsistent, imagine what a 500k codebase will look like.

httpClient and httpErrorHandler yes, client and errorHandler sure, but not http and httpErrorHandler or any other asymmetric and unclear combination.